Stonemax/acme2 finished ACME version2 implementation

#1

Hi

stonemax/acme2, has finished implementation ACME version2 under the master git branch.

I’ve created a pull request to the letsencrypt website; https://github.com/letsencrypt/website/pull/260

#2

Cool. May I ask why you decided not to use curl functions? In various places the client does not seem like it would handle HTTP redirects correctly.

For example in checkHttpChallenge, it is valid for the website to redirect the resource to another domain or URL, but the function would prematurely give a false negative.

Another minor issue with the pre-flight check, the HTTP challenge must start over port 80, so this function would result in a false positive if port 443 succeeds but port 80 doesn’t:

#3

Thanks for your advise！

curl is a good tool, I choosed to use fsoekopen because it’s lightweight and flexible. But I didn’t consider the aspect of HTTP redirects indeed, so I had switched the request provider from fsockopen to curl.

As for the HTTP challenge, I had forced the challenge to be accomplished via http.

All codes had been pushed to github and merged to master branch.

Thanks for you advise again！

#4

Thanks @man! Merged :slight_smile:

#5

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.