Certbot keeps suggesting Ngrok domain

pedrouid · June 24, 2019, 1:52pm

We are working on a Docker setup for a Github repository that generates SSL certificates with Cerbot using an ngnix configuration.

You can view the open PR

The setup is simple using 3 make commands that can be described in the Makefile

Change the nginx/defaultConf to match the url we want

make setup URL=<INSERT_URL>

Build the image

make build

Run the container

make run

You can view the Makefile here

github.com

WalletConnect/node-walletconnect-bridge/blob/f72f428a6f959281c8af57d6ae6399082afafb60/Makefile

# make targets for WalletConnect/node-walletconnect-bridge

HASH := $(shell git rev-parse HEAD)
URL=bridge.mydomain.com
.PHONY: all test clean

default:
	echo "Available tasks: setup, build, clean, renew, run, run_skip_certbot, run_daemon, run_daemon_skip_certbot, update"

setup:
	sed -i -e 's/bridge.mydomain.com/$(URL)/g' nginx/defaultConf && rm -rf nginx/defaultConf-e

build:
	docker build . -t walletconnect/node-walletconnect-bridge 

clean:
	sudo rm -rfv ssl/certbot/* && docker rm -f node-walletconnect-bridge

renew:
	make clean && make run

This file has been truncated. show original

The problem happens when running the Docker container when creating certificates with Certbot using the command

certbot --nginx

Which you can find on Line 48 of the docker-entrypoint.sh file

github.com

WalletConnect/node-walletconnect-bridge/blob/f72f428a6f959281c8af57d6ae6399082afafb60/docker-entrypoint.sh#L48


service nginx start
if [ `ls /source/ssl/certbot` ]; then
  #copy keys from local
  echo "copying previously generated keys"
  mkdir -p /etc/letsencrypt/live
  cp -rf /source/ssl/certbot/* /etc/letsencrypt/live/
else
  if [ "$1" != "--skip-certbot" ]; then
    echo "generating certbot keys"
    #create certificate with certbot
    certbot --nginx
    #copy keys to local for rehydrating
    cp -rfL /etc/letsencrypt/live/* /source/ssl/certbot/
  else
    echo "skipping certbot"
  fi
fi
echo "generated keys"


# finish up
service nginx restart

Certbot asks which name would like to activate HTTPS for, however it will only allow me to choose one which doesn’t match the one from the nginx defaultConf file.

The author of the PR said it used ngrok locally for development thus the cerbot services have cached the domain name.

But I’m using a brand new VPS and I checked if there were any present certificates from Github or on the machine that matched this ngrok domain name so that I could revoke it but I was unsuccesful.

My biggest confusion is how this ngrok domain is persisted using the Docker setup if the certificates are not present in the machine or the repository.

Also this setup is very similar to a previous setup we had in a similar repository and this issue never occurred.

Any help or feedback on this issue would be much appreaciated!

Phil · June 24, 2019, 2:51pm

Hi @pedrouid,

Welcome to the community forum!

I think I found the problem at https://github.com/WalletConnect/node-walletconnect-bridge/pull/30/files#diff-5c29fc0b85522159c4dce0482195bdd8R10

I left a message on the PR too.

pedrouid · June 24, 2019, 2:52pm

Thanks a lot for your help @Phil I can’t believe we missed it!

system · July 24, 2019, 3:03pm

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.