would a if (linux) use linuxlocks() not be a better approach for now so windows based systems are no affected?
I am observing the way that certbot features are written is a linux first and only approach.
I would like to see a change in approach. Hey this is a linux only method so when we write this lets think about how we do this and account for non linux system.
This is a problem throughout certbot. I have even written a powershell script to remove the linux features however the new locks is very hard to work around (having to go through a lot of code) https://github.com/ahaw021/CERTBOT-WINDOWS-BUILD
- os.geteuid method
- using os.rename vs os.replace for expand
- the current locks issue
- augeas parsing of apache files
- openssl detection for certificate checking
I am sure there are other methods which throw issues i just haven’t used them
if the ultimate aim is to make certbot cross system capable (python is cross os capable) then the code needs to be written in a way to support this
i would be more than happy to contribute and test windows methods and function but currently this is not possible
for example:
write files method is a true cross system codebase would have something like.
if(os==linux)
use writeFilesOnLinux() method
if(os==windows)
use writeFilesOnWindows() method
This would let me to write code to account for windows and fix it without impacting linux based systems
I have asked for this previously: Certbot - Better Handling of Folder Creation for Windows
Just my 5 cents
Andrei