Pre/post hooks run OK, but with errors?

gilgongo · September 18, 2024, 8:39am

This isn't a big deal I don't think, but I'm curious...

I have a machine on which I need temporarily to stop a docker container that's running a web server on port 80 during renewal. So I've put pre and post scripts into /etc/letsencrypt/renewal-hooks that bounces the container down/up, like this:

#!/bin/bash

cd /opt/Signal-TLS-Proxy
docker compose down

That works fine, but certbot talks about errors along the way:

Hook 'pre-hook' ran with error output:
 Container signal-tls-proxy-nginx-terminate-1  Stopping
  Container signal-tls-proxy-nginx-relay-1  Stopping
  Container signal-tls-proxy-certbot-1  Stopping
  Container signal-tls-proxy-certbot-1  Stopped
  Container signal-tls-proxy-certbot-1  Removing
  Container signal-tls-proxy-certbot-1  Removed
  Container signal-tls-proxy-nginx-relay-1  Stopped
  Container signal-tls-proxy-nginx-relay-1  Removing
  Container signal-tls-proxy-nginx-relay-1  Removed
  Container signal-tls-proxy-nginx-terminate-1  Stopped
  Container signal-tls-proxy-nginx-terminate-1  Removing
  Container signal-tls-proxy-nginx-terminate-1  Removed
  Network signal-tls-proxy_default  Removing
  Network signal-tls-proxy_default  Removed

When I run the script by hand, I don't see those messages though, which is a bit strange. So I've just directed the outputs to /dev/null as it all seems to work (on a dry-run at least).

Curious as to why certbot interprets these lines as errors though.

Ubuntu 22.04.5 certbot 1.21.0

webprofusion · September 18, 2024, 9:51am

I think if the command outputs to the stderr stream then that's interpreted as an error:

github.com

certbot/certbot/blob/018800c5cccea599e34237dbc2536e6716c1c209/certbot/certbot/display/ops.py#L296


      
              :param str command_name: Human-readable description of the executed command
              :param int returncode: The exit code of the executed command
              :param str stdout: The stdout output of the executed command
              :param str stderr: The stderr output of the executed command
          
              """
              out_s, err_s = stdout.strip(), stderr.strip()
              if returncode != 0:
                  logger.warning("%s reported error code %d", command_name, returncode)
              if out_s:
                  display_util.notify(f"{command_name} ran with output:\n{indent(out_s, ' ')}")
              if err_s:
                  logger.warning("%s ran with error output:\n%s", command_name, indent(err_s, ' '))
          
          
          def _gen_https_names(domains: List[str]) -> str:
              """Returns a string of the https domains.
          
              Domains are formatted nicely with ``https://`` prepended to each.
          
              :param list domains: Each domain is a 'str'

webprofusion · September 18, 2024, 9:52am

It's a bit similar to container is up-to-date reports to stderr · Issue #6482 · docker/compose · GitHub

system · October 18, 2024, 9:53am

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.

Topic		Replies	Views
Pre-hook script not found in PATH Help	3	885	July 14, 2020
`certbot-auto renew` stopped unexpectedly, no error reported Help	4	1437	April 14, 2017
Are --pre-hook and --post-hook AND /etc/letsencrypt/renewal-hooks scripts mutually exclusive? Help	7	23621	July 25, 2019
Docker Certbot , reverse proxy setup advice Help	3	1490	January 8, 2022
Pre & post-hook question Help	5	1850	November 30, 2020

Pre/post hooks run OK, but with errors?

Related topics